Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in the jsdoc comment for the HyperFormula class #1324

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix a typo in the jsdoc comment for the HyperFormula class #1324

merged 2 commits into from
Nov 14, 2023

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Oct 24, 2023 •
edited
Loading

Context

Fix a typo in the jsdoc comment

Originally fixed here by @zackrw

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1323

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba linked an issue Oct 24, 2023 that may be closed by this pull request
[Bug]: Typo in the API reference for HyperFormula class #1323
Closed
@sequba sequba requested a review from evanSe October 24, 2023 13:01
@sequba sequba self-assigned this Oct 24, 2023
@github-actions
Copy link

github-actions bot commented Oct 24, 2023 •
edited
Loading

Performance comparison of head (b133660) vs base (a008c1d)

                                     testName |   base |   head |  change
-------------------------------------------------------------------------
                                      Sheet A | 784.17 | 795.98 |  +1.51%
                                      Sheet B | 271.38 | 270.43 |  -0.35%
                                      Sheet T | 234.31 | 233.75 |  -0.24%
                                Column ranges | 878.97 | 865.71 |  -1.51%
Sheet A:  change value, add/remove row/column |     59 |     64 |  +8.47%
 Sheet B: change value, add/remove row/column |    447 |    437 |  -2.24%
                   Column ranges - add column |    252 |    227 |  -9.92%
                Column ranges - without batch |    663 |    954 | +43.89%
                        Column ranges - batch |    211 |    156 | -26.07%

@sequba sequba changed the title Fix a typo in the jsdoc comment fot the HyperFormula class Fix a typo in the jsdoc comment for the HyperFormula class Nov 14, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #1324 (b133660) into develop (a008c1d) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1324   +/-   ##
========================================
  Coverage    97.27%   97.27%           
========================================
  Files          169      169           
  Lines        14422    14422           
  Branches      3018     3097   +79     
========================================
  Hits         14029    14029           
+ Misses         393      388    -5     
- Partials         0        5    +5
Files Coverage Δ
src/HyperFormula.ts 99.59% <ø> (ø)

... and 3 files with indirect coverage changes

@sequba sequba merged commit b66d0b2 into develop Nov 14, 2023
23 checks passed
@sequba sequba deleted the feature/issue-1323 branch November 14, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanSe evanSe evanSe approved these changes

Assignees

@sequba sequba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Typo in the API reference for HyperFormula class
3 participants
@sequba @evanSe @zackrw